Review Request: possible null pointer crash

Hamish Rodda rodda at kde.org
Thu Mar 5 21:27:55 UTC 2009


On Friday 06 March 2009 01:30:10 Andreas Pakulat wrote:
> > On 2009-03-05 04:57:34, David Nolden wrote:
> > > From looking at the code, this condition seems always to be true. But
> > > for the case it's ever not, it wouldn't hurt having a warning instead
> > > of crashing.
>
> Well, its quite easy: if the item is a file that has a target as parent
> this code will currently crash.
>
> What should we pass to the wizard in case we can't find a folder for the
> item? Just KUrl()?

I guess the code should keep walking up the tree until it can get a url.  If 
not, KUrl() could be returned (and the user would need to specify a 
directory), or the directory of the currently open document.

Cheers,
Hamish




More information about the KDevelop-devel mailing list