Review Request: possible null pointer crash

[Andreas Pakulat]

> On 2009-03-05 04:57:34, David Nolden wrote:
> > From looking at the code, this condition seems always to be true. But for the case it's ever not, it wouldn't hurt having a warning instead of crashing.

Well, its quite easy: if the item is a file that has a target as parent this code will currently crash.

What should we pass to the wizard in case we can't find a folder for the item? Just KUrl()?


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/234/#review363
-----------------------------------------------------------


On 2009-03-05 03:08:07, Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/234/
> -----------------------------------------------------------
> 
> (Updated 2009-03-05 03:08:07)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> I found a pointer which gets its value either in an if() or an else if() block.
> Honestly, I do not really know how the code around there works but Andreas ordered me to post something here, so I did. ;)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevelop/languages/cpp/codegen/simplerefactoring.cpp 935489 
> 
> Diff: http://reviewboard.kde.org/r/234/diff
> 
> 
> Testing
> -------
> 
> Compiled and ran the new class action.
> 
> 
> Thanks,
> 
> Frederik
> 
>