Review Request: generic NormalDeclarationCompletionItem in kdevplatform

[David Nolden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/210/#review312
-----------------------------------------------------------

Ship it!


There is some parts on NormalDeclarationCompletion item that I don't like, I think it should be split into multiple classes(It has overgrown a bit).
But since I'm not planning to do anything about that in near future, it's ok.

- David


On 2009-03-01 03:25:47, Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/210/
> -----------------------------------------------------------
> 
> (Updated 2009-03-01 03:25:47)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> I abstracted NormalDeclarationCompletionItem into kdevplatform so it can be used by other languages. The patch changes also cpp to use the new base class.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevelop/languages/cpp/codecompletion/context.cpp 933539 
>   trunk/KDE/kdevelop/languages/cpp/codecompletion/helpers.cpp 933539 
>   trunk/KDE/kdevelop/languages/cpp/codecompletion/implementationhelperitem.cpp 933539 
>   trunk/KDE/kdevelop/languages/cpp/codecompletion/item.h 933539 
>   trunk/KDE/kdevelop/languages/cpp/codecompletion/item.cpp 933539 
>   trunk/KDE/kdevelop/tools/coverage/CMakeLists.txt 933539 
>   trunk/KDE/kdevplatform/language/CMakeLists.txt 933539 
>   trunk/KDE/kdevplatform/language/codecompletion/normaldeclarationcompletionitem.h PRE-CREATION 
>   trunk/KDE/kdevplatform/language/codecompletion/normaldeclarationcompletionitem.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/210/diff
> 
> 
> Testing
> -------
> 
> Unit-Tests pass, completion works.
> 
> 
> Thanks,
> 
> Niko
> 
>