Review Request: generic NormalDeclarationCompletionItem in kdevplatform

Niko Sams niko.sams at gmail.com
Sun Mar 1 11:25:48 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/210/
-----------------------------------------------------------

Review request for KDevelop.


Summary
-------

I abstracted NormalDeclarationCompletionItem into kdevplatform so it can be used by other languages. The patch changes also cpp to use the new base class.


Diffs
-----

  trunk/KDE/kdevelop/languages/cpp/codecompletion/context.cpp 933539 
  trunk/KDE/kdevelop/languages/cpp/codecompletion/helpers.cpp 933539 
  trunk/KDE/kdevelop/languages/cpp/codecompletion/implementationhelperitem.cpp 933539 
  trunk/KDE/kdevelop/languages/cpp/codecompletion/item.h 933539 
  trunk/KDE/kdevelop/languages/cpp/codecompletion/item.cpp 933539 
  trunk/KDE/kdevelop/tools/coverage/CMakeLists.txt 933539 
  trunk/KDE/kdevplatform/language/CMakeLists.txt 933539 
  trunk/KDE/kdevplatform/language/codecompletion/normaldeclarationcompletionitem.h PRE-CREATION 
  trunk/KDE/kdevplatform/language/codecompletion/normaldeclarationcompletionitem.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/210/diff


Testing
-------

Unit-Tests pass, completion works.


Thanks,

Niko





More information about the KDevelop-devel mailing list