on documentation

[Andreas Pakulat]

On 01.02.09 10:47:12, David nolden wrote:
> Am Sonntag 01 Februar 2009 04:22:00 schrieb Aleix Pol:
> > Hi,
> > I created this interface, based on what david suggested. I added some
> > mockups for a way to create ways to view out of it in playground. I'd like
> > to have something useful tomorrow. If there is nothing against this patch,
> > I'll commit it tomorrow and keep working on the plugins.
> >
> Looks good. Except that giving the parent-widget to documentationWidget(..) 
> looks unneeded, since you can also call setParent(..) if you want.

But thats the standard way in kdevplatform to ask a plugin (or whatever)
for something that should be shown in an already known parent. So we
should use the same pattern here, that way the API is consistent in such
cases.

> Also the documentation should clearly define whether it should return
> the same widget again and again, or create a new one with each call,
> and something about the widget ownership.

Definetly.

Andreas 

-- 
Your fly might be open (but don't check it just now).