Review Request: Each VcsPlugin its own context menu, Changed the VcsCommonPlugin to a helper class for common functionality

[Fabian Wiesel]

> On 2009-04-05 15:25:27, Andreas Pakulat wrote:
> > /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.cpp, line 134
> > <http://reviewboard.kde.org/r/530/diff/1/?file=5031#file5031line134>
> >
> >     Did you reformat the file with astyle or something? Seems like quite some whitespace changes that are unrelated... Not so nice, but OTOH I don't want to put the burden on you to change these back manually...

Yes, according to the KDE-libs coding style. Is there a different one for KDevelop? The code in general doesn't seem to follow a particular one.


> On 2009-04-05 15:25:27, Andreas Pakulat wrote:
> > /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.cpp, line 420
> > <http://reviewboard.kde.org/r/530/diff/1/?file=5031#file5031line420>
> >
> >     Not a real objection to this style, just making sure that you know that a copy of a qlist is really cheap...

Depends on your value on cheap :)


- Fabian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/530/#review834
-----------------------------------------------------------


On 2009-04-05 14:15:56, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/530/
> -----------------------------------------------------------
> 
> (Updated 2009-04-05 14:15:56)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Separating the menus allows one to operate concurring VCSs simultaneously.
> Also for each file in the context of contextMenuExtension() call, the VcsPlugin had to check twice if a file is under version control.
> First, for VcsCommonPlugin::contextMenuExtension(), second time for its own. So the context-menu should be a bit more speedier.
> 
> Also, by making VcsCommonPlugin a helper class, the conversion of the various contexts happens in one place.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.h 949557 
>   /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.cpp 949557 
>   /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.h 949557 
>   /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.cpp 949557 
>   /trunk/KDE/kdevplatform/plugins/vcscommon/CMakeLists.txt 949557 
>   /trunk/KDE/kdevplatform/plugins/vcscommon/Messages.sh 949557 
>   /trunk/KDE/kdevplatform/plugins/vcscommon/kdevvcscommon.desktop 949557 
>   /trunk/KDE/kdevplatform/plugins/vcscommon/kdevvcscommonplugin.h 949557 
>   /trunk/KDE/kdevplatform/plugins/vcscommon/kdevvcscommonplugin.cpp 949557 
>   /trunk/KDE/kdevplatform/vcs/CMakeLists.txt 949557 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.h 949557 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.cpp 949557 
>   /trunk/KDE/kdevplatform/vcs/vcspluginhelper.h 949557 
>   /trunk/KDE/kdevplatform/vcs/vcspluginhelper.cpp 949557 
> 
> Diff: http://reviewboard.kde.org/r/530/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabian
> 
>