[PATCH] fix strange include paths for CMake projects when build/install dir is not set

[Aleix Pol]

Well, I have to do anything about that... I have few items on my short-term
todo list that will make it less of a problem.

I'll get some ideas from this patch.

Thanks Peter!!
Aleix

On Sun, Nov 30, 2008 at 3:40 PM, Peter Oberndorfer <kumbayo84 at arcor.de>wrote:

>
> when build dir is not set fetchBuildDir returns "/"
> replaceBuildDir now creates strange include paths like
> KUrl("file:///") or KUrl("file:///plugins/")
>
> for "#[bin_dir]" or "#[bin_dir]plugins"
>
> Now paths which refer to #[bin_dir] or #[install_dir] are not added
> when bin_dir or install_dir is not set.
>
> ---
> please check if this change is desirable, and the right way to fix the
> problem.
> if it is right please apply for me (i have no SVN access)
>
> open points:
> *KUrl documenation warns about KUrl(const QString&)
> -> maybe use setPath() but other parts also use the constructor
>
> *automatic conversion from const QString to QString on replaceXxxxDir call
> is this OK?, i think yes.
>
>  plugins/managers/cmake/cmakemanager.cpp |   25 +++++++++++++++++--------
>  1 files changed, 17 insertions(+), 8 deletions(-)
>
>
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20081130/e301cce5/attachment-0001.html>