[PATCH] fix strange include paths for CMake projects when build/install dir is not set

Peter Oberndorfer kumbayo84 at arcor.de
Sun Nov 30 14:40:20 UTC 2008


when build dir is not set fetchBuildDir returns "/"
replaceBuildDir now creates strange include paths like
KUrl("file:///") or KUrl("file:///plugins/")

for "#[bin_dir]" or "#[bin_dir]plugins"

Now paths which refer to #[bin_dir] or #[install_dir] are not added
when bin_dir or install_dir is not set.

---
please check if this change is desirable, and the right way to fix the problem.
if it is right please apply for me (i have no SVN access)

open points:
*KUrl documenation warns about KUrl(const QString&)
-> maybe use setPath() but other parts also use the constructor

*automatic conversion from const QString to QString on replaceXxxxDir call
is this OK?, i think yes.

 plugins/managers/cmake/cmakemanager.cpp |   25 +++++++++++++++++--------
 1 files changed, 17 insertions(+), 8 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 5dfd74095ba99fe9ba072567418a1f6a1d4ebe5d.diff
Type: text/x-patch
Size: 2426 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20081130/5fbfb905/attachment.diff>


More information about the KDevelop-devel mailing list