KDE/kdevplatform

[Hamish Rodda]

On Mon, 9 Jun 2008 05:49:37 pm Andreas Pakulat wrote:
> On 09.06.08 06:19:32, Hamish Rodda wrote:
> > Large refactoring to allow running state of plugins to be shown to the
> > user, and jobs to be killed...:
>
> Coool. Your shift must have been really boring ;)

Yeah, 2x 13 hour shifts with mostly nothing to do :)

> > Add a menu option for selecting which project should be run, so the run
> > configuration works again (but not the add target feature, will work on
> > that later)
>
> Looking at the changes this goes the same way as the "configure project"
> thing, which means sooner or later it'll (hopefully) vanish from the
> main menu. Menu items that need some context to work, need to be in a
> context menu.

Yep, I'd be very happy to see this change to a right click option on the 
project in the project viewer.

> > Port to KJob
> > - cvs plugin
> > - svn plugin (could only find one place that jobs are started, is that
> > correct??)
>
> Yes and no :) The svn plugin itself starts all the jobs that are added
> to the context menu. However it does so by running KJob::exec() so the
> job is executed synchronously and then can be deleted. With
> auto-deletion of these jobs being done anyway I guess this can be
> changed to job->start() and the delete be removed. Dunno why I didn't do
> that :)
>
> Also there are some start()'s in vcs/widgets/
>
> I've put both of these on my list for tonight, unless you beat me to it.

They're all yours :)

> Oh and I don't really like the casting here and in "defaultRun":
> +    action->setData(QVariant::fromValue(static_cast<void*>(project)));
> +
> +    if (!d->defaultTargetAction->currentAction())
> +        action->setChecked(true);
> +}
>
> How about using the project name in there and then use
> ProjectController::findProjectByName(). The names are guaranteed to be
> unique (or rather we expect them to be).

I guess we can do that.

> Hmm, shouldn't OutputJob be in the output library? Its closely related
> to the outputview and somehow doesn't seem to be in the right spot in
> util/

Oh, right :)

Cheers,
Hamish
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20080609/33f2a21b/attachment.sig>