Crash after requesting context menu (after reopening the project)
apaku at gmx.de
Thu Jul 31 09:48:35 UTC 2008
On 31.07.08 11:32:38, Manuel Breugelmans wrote:
> On Thursday 31 July 2008 11:22:03 Andreas Pakulat wrote:
> > On 31.07.08 10:31:48, Manuel Breugelmans wrote:
> > > Whenever you feel like a chunk of code is non trivial enough to comment
> > > it, use an ExtractMethod refactoring instead. I would say keep that.
> > Well, I don't think this code is fitting into that. Its pretty straight
> > forward IMHO.
> There's plenty of comments there though. The thing is that you want code to be
> readable for people not familiar with a particular component, like I was. If
> they think it is not reading fluently, it should be re-factored.
> 'unloadUnusedPlugins()' shows much better what is going on and allows a reader
> to skip it if that's not what they are looking for, rather than getting
> overwhelmed with details.
Hmm, my preference is over having the details in the place as opposed to
having to jump to another place and then go back to where I was.
Especially when I'm debugging things and am not sure which path the code
is taking or whats happening inside a function. I find myself in this
position quite a lot.
Anyway, as I'm pretty familiar with this specific piece of code and thus
am possibly the wrong person to judge about this. So if it helps your
understanding please commit the refactoring of the function.
Cheer Up! Things are getting worse at a slower rate.
More information about the KDevelop-devel