KDE/kdevplatform/veritas

[Andreas Pakulat]

On 17.07.08 12:05:20, Manuel Breugelmans wrote:
> On Thursday 17 July 2008 11:16:42 Andreas Pakulat wrote:
> > On 17.07.08 09:34:48, Manuel Breugelmans wrote:
> > > On Thursday 17 July 2008 09:28:19 Andreas Pakulat wrote:
> > > > On 17.07.08 09:10:04, Manuel Breugelmans wrote:
> > > > > On Thursday 17 July 2008 08:58:01 Andreas Pakulat wrote:
> > > > > > On 16.07.08 22:35:54, Carlo Segato wrote:
> > > > > > > SVN commit 833510 by segato:
> > > > > > >
> > > > > > > disable fvisibility=default on windows
> > > > > >
> > > > > > This doesn't look right (neither for win32 nor in general). It
> > > > > > seems the needed symbols are not properly exported. Manuel?
> > > > >
> > > > > I'm going to need a bit more information. That fvisiblity=default is
> > > > > conditional, for 'TestBuilds' only so I dont have to compile things
> > > > > twice to do proper unittesting of (otherwise hidden) library classes.
> > > >
> > > > Well, as you can see in the code its always on, which means the whole
> > > > library is exposed not only for tests.
> > >
> > > The idea was to turn it off when doing a release build. Probably this can
> > > somehow be fixed automatically with cmake?
> >
> > Aah, right, totally forgot this. Unless I'm mistaken you only need this
> > when building the tests, right? Then you can just use the
> > KDE4_BUILD_TESTS cmake variable as a check, thats only set when one
> > builds the tests and thus you only export all symbols when test-building
> > is enabled.
> >
> > Andreas
> 
> That's not a perfect solution. When the KDE4_BUILD_TESTS variable is off, cmake  
> generates an extra make target 'buildtests'.

Ah, forgot about that.

> So invoking `make && make buildtests' will not compile. Proper
> solution is probably something with CMAKE_BUILD_TYPE.

No, proper solution is to include the .cpp files that you want to test
directly, or build another library thats not installed but just used for
the tests (which then uses default visibility).

Using the build-type is not the proper way of deciding wether tests
should be built or not.

Andreas

-- 
Write yourself a threatening letter and pen a defiant reply.