[kdev3.5] Bug 153642, grepview + patch

[Andreas Pakulat]

On 05.02.08 23:26:54, David Nolden wrote:
> On Tuesday 05 February 2008 22:35:51 Bernd Buschinski wrote:
> > I have no clue why it was backported from kdev4, I dont like timers at all
> > and settings the timeout to 200ms wont help mutch in my opinion.
> > Because the timeout deletes text from an used buffer, I mean durring the
> > 200ms (and maybe longer) the buffer is still used and stuff is added and
> > deleted, and nobody has a clue whats happening after exatcly 200ms.
> >
> > Maybe I am wrong, but removing the timer looks like the best option to me
> > :) The patch fixes the bug, or at least I couldnt find any choped messages.
> >
> > And by the way if this bug is fixed I am fine with the kdev-3.5.1 release
> > :)
> 
> Doesn't this have the effect that you can only see the results after the WHOLE 
> search process has finished? I suspect the current implementation returns 
> them already earlier, so this would be a little regression.

No, the KProcess emits its "got data on stdou/err" signals multiple
times while it runs. I'm actually not quite sure right now what the
timer was for, but Ossi usually doesn't do such things without good
reason :)

Andreas

-- 
You teach best what you most need to learn.