[CMake] FindBoost.cmake updated on the bugtracker

Andreas Pakulat apaku at gmx.de
Tue Apr 1 21:57:20 UTC 2008


On 01.04.08 16:37:42, Matthew Woehlke wrote:
> Andreas Pakulat wrote:
>> On 31.03.08 20:14:00, Matthew Woehlke wrote:
>> Also note that those variables you use in
>> find_path are automatically cached and I don't think they should appear
>> in it.
>>
>> Apart from that, you're iterating over all test versions, thats
>> unecessary.
>
> Um... no. Here's what happens without the patch:

Exactly what I suspected. So would you mind explaining why you can't use
the version in /usr? I'd just like to know wether the script might
actually need a minimum as well as a maximum number, because boost
doesn't play by the rules and breaks source/binary compatibility.

> Here's an updated patch (note that I used --ignore-all-spaces to diff so  
> the indentation changes don't make it noisier than it needs to be):

Which still has the two problems

a) it puts two completely useless variables into the cache
b) it doesn't break the loop as soon as it finds a proper include dir
(hmm, maybe thats actually needed - I'll have a closer look tomorrow,
need some sleep now).

I'm leaning towards agreement, but am not yet completely convinced that
its absolutely necessary to go on searching for "preferred" paths even
if the system path meets the expectations (i.e. has a version that is
larger than the minimum required).

Andreas

-- 
You could live a better life, if you had a better mind and a better body.




More information about the KDevelop-devel mailing list