KDE/kdevelop/lib/plugins/vcs/interfaces

[Andreas Pakulat]

On 31.05.07 16:41:24, Matt Rogers wrote:
> On Thursday 31 May 2007 16:26, Andreas Pakulat wrote:
> > On 31.05.07 15:20:42, Matt Rogers wrote:
> > > My objection is that we have no one using this functionality already and
> > > it overlaps with already existing functionality (aka command line
> > > clients). It seems like we're just adding it because we think it would be
> > > cool. If people want to write scripts to interact with version control
> > > systems, they should use the command line version of said version control
> > > system. The only version control system that doesn't have an command line
> > > version is Visual SourceSafe and I don't want to support that from within
> > > KDevelop anyways.
> >
> > So we should just drop what we have and revert to the interface we have
> > implemented already?
> >
> 
> No. Perhaps my problem is that I don't understand why we need the distinction 
> between showLog and just log (and don't say it's for scripts) when, IMHO, 
> we , as users of the interface, should just call a function, and have it do 
> the right thing (either show a gui or not based on the information available) 
> and give us the information we want, but perhaps this is too difficult or 
> magical. 

Well, it doesn't quite work very well: Some piece of code calls diff()
with proper methods, but it didn't want to get back the diff, it wanted
to have a Ui with the diff displayed. Or the other way around. Using the
show() methods you can either explicitly ask for a gui or not.

Of course we could add another parameter to all the methods for that,
but I think that just clutters the signature for no good reason.

> > Also quite some of the functionality may be used by other plugins, think
> > about getting a diff to head and sending that through teamwork to
> > somebody who doesn't have access to the vcs (for whatever reason). Its
> > not simply about scripts, its about exposing part of the functionality
> > of the VCS in a way that is usable by other code and not just displayed
> > to the user.
> >
> > Andreas, who will continue to work on new interfaces and help the VCS
> > authors to implement them
> 
> Yes, we need to be able to implement functionality like this. If this is the 
> one of the reason for the difference between showLog and log, then that's 
> fine and I withdraw my objections.

Yes it is, scripting is not the only possible use-case. I know we're
doing quite a bit of guessing here, but I expect at least things like
add/remove/copy/move to become used within the next months.

Andreas

-- 
You are sick, twisted and perverted.  I like that in a person.