IBasicVersionControl (first try)

[Andreas Pakulat]

On 30.05.07 17:00:15, Matthew Woehlke wrote:
> Andreas Pakulat wrote:
> >On 30.05.07 15:04:58, Matthew Woehlke wrote:
> >>Robert Gruber wrote:
> >>>*) "Modified" is defined twice in KDevelop namespace, so I renamed the 
> >>>second one to FileModified
> >>Shouldn't this be ItemModified? (And s/File/Item/g in the doc of course...). 
> >>Maybe we should change the others to e.g. ItemAdded, etc. or at least e.g. 
> >>Added for more consistency. (It might make sense to only prefix *Modified; 
> >>this makes it clear there is a difference in object type for these, whereas 
> >>the others apply to items or directories.)
> >Its already called "Added",
> 
> I'm looking at VcsAction. :-) (...which should be Action, also.)

Ok.

> >I agree we should s/Foo/ItemFoo/ for the VcsState.
> 
> That isn't what I was talking about, but it makes sense for VcsState. I guess 
> then we leave VcsEvent::Action::Modified alone? (But can we make them 
> past-tense for consistency?)

Yes.

> Proposed patch attached. I moved Actions to avoid a circular dependency 
> (resolvable, but IMO it makes more sense for Actions to belong to VcsItemEvent 
> anyway).

Agreed.

> For QFlags is it needed to specify values for the enum?

Uhm, I think so, i.e. 0 1 2 4 8 16..

Please commit when you've added the values.

Andreas

-- 
You look like a million dollars.  All green and wrinkled.