VcsJob question and suggestion

[Andreas Pakulat]

On 29.05.07 14:46:24, Matthew Woehlke wrote:
> Andreas Pakulat wrote:
> > diff returns ???
> > 
> > Seems like diff got lost along the way, basically it would be just a
> > small class around QPair<QString,QString> for text files.
> 
> Hmm... yes, that /should/ work but we may need to differentiate between 
> 'the files, verbatim' and 'a copy of A plus the diff (a,b)'. It seems 
> like QByteArray would work for binary files although I'm not very 
> familiar with it.

Yeap, seems QByteArray is fine. So we'd have a QPair<QString,QString> or
QPair<QByteArray,QByteArray>. Differing between two files and 1
file+diff can be done using the type (it is not only usable for
requesting, but also for checking later on).

> > Well, if we have finishStatus() then we don't need the special
> > finished() signal and can go with the result() signal.
> 
> To make sure I understand this: this means there will be a 'still 
> running' value returned from finishedStatus() and you have to check this 
> every time in result() to know if you are done?

result() is a KJob signal, but actually its private as well. I need to
ask k-c-d on what exactly is the purpose here. The signals from the API
dox seem to be the only non-private ones. resultsReady() will stay.

Andreas

-- 
You are confused; but this is your normal state.