VcsJob question and suggestion

[Matthew Woehlke]

Andreas Pakulat wrote:
> AFAICS:
> 
> log returns VcsEvent
> annotate returns VcsAnnotation

Right. (change() also returns VcsEvent IIRC)

> diff returns ???
> 
> Seems like diff got lost along the way, basically it would be just a
> small class around QPair<QString,QString> for text files.

Hmm... yes, that /should/ work but we may need to differentiate between 
'the files, verbatim' and 'a copy of A plus the diff (a,b)'. It seems 
like QByteArray would work for binary files although I'm not very 
familiar with it.

I actually realized there /is/ a use case for wanting /only/ the diff. 
You might want it to generate commit messages. You also might want it if 
you are generating a 'time lapse' view of a file (one reason for this 
would be to 'fake' an annotate() if the VCS doesn't support it, and/or 
to implement a 'time lapse view').

> Well, if we have finishStatus() then we don't need the special
> finished() signal and can go with the result() signal.

To make sure I understand this: this means there will be a 'still 
running' value returned from finishedStatus() and you have to check this 
every time in result() to know if you are done?

-- 
Matthew
"A mouse is a device used to point at the xterm you want to type in."
   --Kim Alm, A.S.R.