[VCS] Merging IAtomic* into IBasic*

Andreas Pakulat apaku at gmx.de
Tue May 15 17:48:29 UTC 2007


On 15.05.07 11:25:11, Matthew Woehlke wrote:
> Andreas Pakulat wrote:
> > On 11.05.07 12:54:14, Matthew Woehlke wrote:
> >> Andreas Pakulat wrote:
> >>> On 11.05.07 11:00:41, Matthew Woehlke wrote:
> >>>>> So there are functions in our interfaces that don't take a repo or local
> >>>>> path.
> >>>> Right now change() only takes a VcsRevision. That might be the only one, 
> >>>> I haven't done an audit yet.
> >>> Ok, yeah. I think the revision should take the repo-information
> >>> (internally like the repo path for filenumbers)
> >> Hmm... at first that makes a lot of sense, but the problem is I can't 
> >> think of a way to do change(VcsRevision::Head) this way. Is it better to 
> >> require constructing a VcsRevision to require a repo path, or should we 
> >> just say that change() needs a repo path?
> > 
> > Hmm, I think change() should then also take a repo path. We could attach
> > the path to the revision itself, but then we'd have duplicate stuff in
> > all methods that already take a path and you always have to create new
> > VcsRevision objects when you want to work with the same date on a
> > different path...
> 
> Heh. Ok, let's see... a FileNumber revision still needs a path, but I 
> don't think there is a way to construct such a critter (nor do I 
> particularly feel that there should be), especially since not all VCS's 
> will support FileNumber revisions (e.g. svn won't). The other 
> interesting effect is that if change() takes a repository path, I guess 
> CVS can actually support it, in which case it can move to IBrowsableVC 
> after all. Any objections?

IBrowsable? I thought more of IBasic, I mean its pretty basic stuff
IMHO and its not really something you use when browsing a VCS in a
repo-browser, right?

> (Sorry for the delay, was visiting maternal relatives, it being Mother's 
> Day and all :-).)

Oh, I don't mind. Luckily I've got my mother around still :)

Andreas

PS: And just for those who are not aware (i.e. any non-german readers),
I doubt I'll be available anytime between thursday noon til friday noon
- so called mans day in Germany :)

-- 
You'll be sorry...




More information about the KDevelop-devel mailing list