VcsJob, two quick questions

[Andreas Pakulat]

On 08.05.07 17:07:58, Matthew Woehlke wrote:
> Andreas Pakulat wrote:
> > On 07.05.07 10:43:27, Matthew Woehlke wrote:
> >> Preference? Done, Cancelled, Error - or - Succeeded, Failed, Cancelled?
> > 
> > The 2nd is better IMHO. Done doesn't really imply that it is sucessfully
> > done - to me.
> 
> Agreed... didn't *you* write Done? ;-)

Didn't I mention I did so late at night? ;)

> >> Should we also provide fetchNewResults? Or is that too much work for too 
> >> little benefit?
> > 
> > Oh, the api dox are not clear, after one fetchResults() call the vcsjobs
> > internal buffer is emptied. Just like QProcess works, once you've read
> > the output the internal buffer is emptied. A vcs job shouldn't be
> > something that lives very long once its finished.
> 
> Hmm... ok, so the caller is responsible for collating results if it 
> reads them in incrementally? I was thinking that seemed more 
> complicated,

Well, appending the output to some list or even just piping it directly
into a stream (like a textstream to a file) is really easy, IMHO.

Andreas

-- 
It's all in the mind, ya know.