REMINDER: Final review of VCS interfaces

Matt Rogers mattr at kde.org
Mon Jun 4 18:47:21 UTC 2007


On Jun 4, 2007, at 1:26 PM, Robert Gruber wrote:

>
> On Fri, 01 Jun 2007 14:11:11 Matthew Woehlke wrote:
>> Robert Gruber wrote:
>>> Index: interfaces/vcshelpers.h
>>> ===================================================================
>>> --- interfaces/vcshelpers.h	(Revision 670496)
>>> +++ interfaces/vcshelpers.h	(Arbeitskopie)
>>> @@ -22,6 +22,9 @@
>>>  #ifndef VCSHELPERS_H
>>>  #define VCSHELPERS_H
>>>
>>> +#include <QVariant>
>>> +#include <KUrl>
>>> +
>>>  #include "vcsexport.h"
>>
>> Hmm, non-self-contained header... we bad :-).
>
>
> I've added some other missing things like namespaces and interface  
> declaration. See attached patch.
> Any objections? Or can I commit...
>
> Robert

No objections. Please commit.

Matt






More information about the KDevelop-devel mailing list