REMINDER: Final review of VCS interfaces

[Matthew Woehlke]

Robert Gruber wrote:
> Could you or somebody else please try to temporary apply the 
> attached patch to his local copy and tell me if you get the
> same error? Or have I done something completely wrong?
> 
> Index: interfaces/vcshelpers.h
> ===================================================================
> --- interfaces/vcshelpers.h	(Revision 670496)
> +++ interfaces/vcshelpers.h	(Arbeitskopie)
> @@ -22,6 +22,9 @@
>  #ifndef VCSHELPERS_H
>  #define VCSHELPERS_H
>  
> +#include <QVariant>
> +#include <KUrl>
> +
>  #include "vcsexport.h"

Hmm, non-self-contained header... we bad :-).

Anyone see anything wrong with this, or can I commit as obvious?


Index: vcshelpers.h
===================================================================
--- vcshelpers.h        (revision 670471)
+++ vcshelpers.h        (working copy)
@@ -22,6 +22,10 @@
  #ifndef VCSHELPERS_H
  #define VCSHELPERS_H

+#include <QString>
+#include <QVariant>
+#include <KUrl>
+
  #include "vcsexport.h"

  namespace KDevelop
Index: ibranchingversioncontrol.h
===================================================================
--- ibranchingversioncontrol.h  (revision 670476)
+++ ibranchingversioncontrol.h  (working copy)
@@ -22,6 +22,8 @@
  #ifndef IBRANCHINGVERSIONCONTROL_H
  #define IBRANCHINGVERSIONCONTROL_H

+#include "vcshelpers.h"
+
  namespace KDevelop
  {

Index: irepositoryversioncontrol.h
===================================================================
--- irepositoryversioncontrol.h (revision 670476)
+++ irepositoryversioncontrol.h (working copy)
@@ -22,6 +22,8 @@
  #ifndef IREPOSITORYVERSIONCONTROL_H
  #define IREPOSITORYVERSIONCONTROL_H

+#include "vcshelpers.h"
+
  class KDEVPLATFORMVCS_EXPORT IRepositoryVersionControl
  {
  public:
Index: ibrowsableversioncontrol.h
===================================================================
--- ibrowsableversioncontrol.h  (revision 670476)
+++ ibrowsableversioncontrol.h  (working copy)
@@ -22,6 +22,8 @@
  #ifndef IBROWSABLEVERSIONCONTROL_H
  #define IBROWSABLEVERSIONCONTROL_H

+#include "vcshelpers.h"
+
  class KDEVPLATFORMVCS_EXPORT IBrowsableVersionControl
  {
  public:
Index: idistributedversioncontrol.h
===================================================================
--- idistributedversioncontrol.h        (revision 670471)
+++ idistributedversioncontrol.h        (working copy)
@@ -21,6 +21,8 @@
  #ifndef IDISTRIBUTEDVERSIONCONTROL_H
  #define IDISTRIBUTEDVERSIONCONTROL_H

+#include "vcshelpers.h"
+
  /**
   * This interface has methods to support distributed version [snip]
   * like git or svk

-- 
Matthew
"943. I am not Bjorn of Borg."
  -- from 975 things Mr. Welch can no longer do in an RPG
http://theglen.livejournal.com/16735.html