Removing some things from C++ parser

Matt Rogers mattr at kde.org
Thu Jul 26 04:29:57 UTC 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On Jul 25, 2007, at 9:28 PM, Andreas Pakulat wrote:

> On 26.07.07 00:53:50, David Nolden wrote:
>> Am Donnerstag, 26. Juli 2007 00:39:02 schrieb Andreas Pakulat:
>>> David: Do you mind if I do that change this weekend - would mean  
>>> having 1
>>> CMakeLists.txt in the cpp folder, not sure yet how to do the  
>>> tests then,
>>> either separate files or also in the main 1. If you think this might
>>> disturb you too much in your SoC I can postpone it after that.  
>>> (CC'ing
>>> you as you said you don't get any list-mails)
>>
>> I probably won't be working on it in the weekend, so I don't mind.
>
> Oh, cool (I actually expected the opposite answer :)
>
>> The question is how we do make the tests continue working. Maybe
>> static-linking them against the c++ plugin would be the easiest way.
>
> Thats going to be a no-brainer: use different CMake variables for all
> "parts" and then the tests include their test + the needed parts.
> Something like this:
>
> set(duchainbuilder_SRCS .... )
> set(parser_SRCS ... )
>
> kde4_add_unit_test(duchaintest ${duchaintest_SRCS} $ 
> {duchain_SRCS} ...)
>
> Well, you get the idea.
>
> Andreas

I'd recommend having a shared library that contains all the parser  
stuff which the tests can link against rather than pulling in the  
sources for the particular things to test. You would also be able to  
link the plugin against the shared library as well. There's nothing  
saying that any installed shared library has to have public headers,  
so we can just not install those and be ok.

- --
Matt


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (Darwin)

iD8DBQFGqCNFA6Vv5rghv0cRArzNAJ49mUEb2LaSOFuCAwJw/xNwMv0v+ACfTxjM
LBJlGp26kGf3mkw3R0eBwAM=
=QTqA
-----END PGP SIGNATURE-----




More information about the KDevelop-devel mailing list