[Patch] Window history

[Jens Dagerbo]

On Monday 12 February 2007 02.15.47 Paulo Moura Guedes wrote:
> On Saturday 03 February 2007 22:20, Jörg Rüppel wrote:
> > Paulo Moura Guedes wrote:
> > > The attached patch allows to popup a menu that has a list of documents,
> > > sorted by visit order, just like the window manager ALT-Tab.
> > > Usually CTRL-Tab is used has a shortcut but has it is a very busy
> > > shortcut in KDE, CTRL[-SHIFT]-F6 was choosen for default (just like in
> > > Eclipse).
> >
> > Is someone going to apply this? I'd really like to see this in KDevelop.
>
> AFAIK it won't be applied because it's a big patch and it uses a parallel
> history (because the current one doesn't do what is needed).
> As the main window code will be discontinued for KDE 4 and the patch can't
> break anything I don't understand the reason why though.
>

Since it sounds like you're quoting me, I guess I should respond. :) I was 
waiting for someone else to chime in.. has anyone else tested the patch? 
Opinions?

I finally actually tried the patch last night, and it does more or less what 
advertised. 

Some minor issues:
1. I just couldn't get the shortcuts to work, even when reconfiguring them 
from their default (switch to 6th/18th desktop (!!!)). I used ctrl+shift+N 
(next) and ctrl+shift+P (previous) and lo, I got the menu. I doubt there is 
anything wrong in the patch, must be some KDE borkage.

2. The popup menu appears in the middle of screen 0. This is fine if that's 
where KDevelop is, but in my TwinView setup I had KDevelop on screen 1 when I 
tested the patch and at first didn't even see the popup. I guess the popup 
should probably center on the application window, rather than the desktop.

Pro:
Nice feature. Works well.
Readable high quality code
Manages to remember switches done via tabwidget

Con:
Well.. nothing really, except it's a non-trivial amount of code for a rather 
marginal feature. It brings a second implementation of history with a third 
way of stepping between open documents (the other two being navigation 
history and tab-order based next/previous window). This in addition to Window 
menu, QuickOpen based open files switcher and the FileList. Do we really 
want/need this?

Opinions?

// jens