Removing Makefile-things from buildmanager API

[Matt Rogers]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On Aug 3, 2007, at 4:25 AM, Andreas Pakulat wrote:

> On 02.08.07 22:30:07, Matt Rogers wrote:
>> On Thursday 02 August 2007 20:48, Andreas Pakulat wrote:
>>> Hi,
>>>
>>> Are there any objections against removing the *Makefile*  
>>> functions from
>>> the BuildManager interface? I can't see how those fit into a general
>>> buildmanager API as there are tons of buildmanagers out there  
>>> that don't
>>> use Makefile under the hood.
>>>
>>> Andreas
>>
>> Could you do a bit of extra work and tell us what the names of  
>> those functions
>> are?
>
> Sure:
>     /** @return The Makefile associated with the specified @p folder.
>      *   @note The Makefile list must contain absolute file names
>      *
>      * For instance, in <b>Automake</b> projects you can use  
> something like:
>      * @code
>      * return dom->name() + "/Makefile.am";
>      * @endcode
>      */
>     virtual KUrl findMakefile(ProjectFolderItem* folder) const = 0;
>
>     /** @return The list of the Makefiles from the @p folder.
>     @note The Makefile list must contains absolute file names */
>     virtual KUrl::List findMakefiles(ProjectFolderItem* folder)  
> const = 0;
>

I think these can be removed too. If we need replacements, we can add  
them later.

> Not sure wether the same applies to this
>     /**
>      * Provide a list of files that contain the preprocessor  
> defines for the
>      * project
>      */
>     virtual KUrl::List preprocessorDefines(ProjectBaseItem*) const  
> = 0;
>

This can be removed.

> Its also a C/C++ specific feature, but then we have already the  
> Features
> enum which can tell wether this function returns useful results.
>
> Andreas
>
> -- 
> You love your home and want it to be beautiful.
>
> _______________________________________________
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

Matt


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (Darwin)

iD8DBQFGs4PMA6Vv5rghv0cRAp5OAKC1i5WRDhcatFRb3ExdkYLGVWf0wACfUk+H
Fj3be8VvtthN8n2+d0S2mNQ=
=ML6+
-----END PGP SIGNATURE-----