[KDev4] CVS plugin

[Matt Rogers]

On Apr 11, 2007, at 3:05 AM, Robert Gruber wrote:

> Hello,
>
> I just committed a first version of my CVS plugin for KDevelop4.
> Currently it's only possible to run actions via the menubar. The  
> action is
> always performed on the currently displayed file.
>
>
> The output of basic actions like "cvs add", "cvs update", "cvs  
> edit", "cvs
> unedit"... gets continuously written as plain text to the first  
> tabwidget of the outputview.
>
> More advanced actions like "cvs diff", "cvs log", "cvs editors"...  
> will create a new tabwidget which allows to display their output  
> more beautified. This is currently only implemented for "cvs editors"
>
> Any comments are welcome....
>
> Robert
>
>

Several issues, all of which (I would like to point out), would have  
been avoided had such a patch been posted to the list for review a  
day or two in advance of committing. So, in no particular order:

1. No documentation, unless there's some in the code, which I've yet  
to look at. An explanation of how the plugin is designed, where  
people can find things, etc. would be nice to have. Makes it easier  
for others to go looking through the code for hints, tips, and examples.
2. No testing. How do we know it works? Are you sure it doesn't have  
any bugs? How do we prevent the code from regressing while developing  
it? Adding tests answers all three of those questions. Please  
consider adding some unit and/or functional tests. Qt provides a nice  
library called QTestLib for that sort of thing.
3. Filenames, and possibly classnames that are abbreviated. Please s/ 
dlg/dialog/ in your filenames and your classnames if you followed the  
filename  = classname convention.
4. files with underscores in their name. please remove those.

Those are the things that I see just by looking at email of the  
commit. I'll look through the code a bit later.
--
Matt