KDE/kdevelop/lib/plugins/vcs/subversion

[Andreas Pakulat]

Sorry, first try was CCed to kdevelop-devel at kde.org :(

On 08.04.07 18:51:56, Dukju Ahn wrote:
> SVN commit 651647 by dukjuahn:
> 
> Use KDialog instead of QDialog.
> Removed designer *.ui file and used direct coding.

Our policy is to do all user interfaces with .ui files, although this
one is rather simple I think it should stay as .ui file. You can just
change QDialog->KDialog in the .ui file if thats been the reason. 

> --- trunk/KDE/kdevelop/lib/plugins/vcs/subversion/subversion_core.cpp #651646:651647
> @@ -1502,7 +1502,7 @@
>      
>      dlg->setAttribute( Qt::WA_DeleteOnClose );
>      connect( job, SIGNAL(finished()), dlg, SLOT(close()) );
> -    connect( dlg, SIGNAL(rejected()), job, SLOT(terminate()) );
> +	connect( dlg, SIGNAL(finished()), job, SLOT(terminate()) );

Would you please keep the indentation consistent and according to our
policy.

> -    Ui::SvnProgressDialog::setupUi(this);
> -    setWindowTitle( caption );
> +	setCaption( caption );

Same thing here.

Andreas

-- 
You may worry about your hair-do today, but tomorrow much peanut butter will
be sold.