branches/kdevelop/3.4/src

[David Nolden]

Am Samstag, 16. September 2006 02:03 schrieb Jens Dagerbo:
>
> Since the patch actually goes in a "loop" until it has managed to set the
> line number, I would be surprised if it isn't possible to get it to
> misbehave.
>
> I haven't been able to make it cause any noticeable slowdowns, but it
> didn't take long to come up with a usecase that makes it crash KDevelop.
> (While it is looping, unload one of the documents it is trying to set the
> cursor on.)
>
> Other issues:
> We have a method called "setLineNumber" - where would you expect the cursor
> to be after this call? Clearly unexpected behaviour.
> Also, since the problem is actually the setCursorPositionReal() call and we
> use that directly elsewhere in the code we would have to come up with a
> solution here as well.
>
> What is the fix in the Kate code, btw? If it's this "loop fix" there as
> well I think this is really dangerous.
>
>
> A third party extension to Qt is making katepart crash, which makes
> KDevelop crash. Trying to paper over this in KDevelop is the wrong fix. It
> stinks that this bug has been around for 2 years now, but I don't think
> that is a good enough reason to introduce problems and bugs (which this
> patch does, even if it also helps) where it isn't needed. (Don't have the
> XIM patch? Don't need the fix, dont' want the bugs.)
>
> I wish I could offer a solution though. Is anyone up to fixing the XIM
> patch? :(
>
> // jens

I changed the patch so it uses only exactly one timer with a delay of one 
millisecond. This should prevent the problem I encountered, but of course it 
still isn't good. It is still possible to produce a crash, it is just a bit 
harder, there's still the unexpected behavior, and sometimes a bit strange 
things happen to the focus.

But I fear currently there's nothing better we can do, at least until the 
kate-fix is in most mainstream-distributions..

Just by the way, the terminal-emulator sometimes suffers from the same crash. 
I hope Kubuntu will ship a fixed KDE soon. :) We should add a macro that only 
activates the patch on systems where the KDE-Version is not yet fixed. Then 
you won't get the bugs. :)

greetings, David