ready

[Andras Mantia]

On Friday 19 May 2006 12:27, David Nolden wrote:
> Ok, the patch is up now and it seems like I didn't break anything..

No, it doesn't work:

dgets/.deps/fancyklistviewitem.TUlo
/data/development/sources/kde-3.5/kdevelop-3.4/lib/widgets/fancylistviewitem.cpp:29: 
error: definition of ‘void FancyKListViewItem::init(const QString&, 
const QString&)’ is not in namespace enclosing ‘FancyKListViewItem’
/data/development/sources/kde-3.5/kdevelop-3.4/lib/widgets/fancylistviewitem.cpp:29: 
warning: unused parameter ‘label2’
/data/development/sources/kde-3.5/kdevelop-3.4/lib/widgets/fancylistviewitem.cpp:36: 
error: definition of ‘void FancyKListViewItem::setItem(int, 
TextPaintItem)’ is not in namespace enclosing ‘FancyKListViewItem’
/data/development/sources/kde-3.5/kdevelop-3.4/lib/widgets/fancylistviewitem.cpp:45: 
error: definition of ‘void FancyKListViewItem::setText(int, const 
QString&)’ is not in namespace enclosing ‘FancyKListViewItem’
/data/development/sources/kde-3.5/kdevelop-3.4/lib/widgets/fancylistviewitem.cpp:54: 
error: definition of ‘QString FancyKListViewItem::text(int)’ is not in 
namespace enclosing ‘FancyKListViewItem’
/data/development/sources/kde-3.5/kdevelop-3.4/lib/widgets/fancylistviewitem.cpp:61: 
error: definition of ‘QColor FancyKListViewItem::backgroundColor(int)’ 
is not in namespace enclosing ‘FancyKListViewItem’
/data/development/sources/kde-3.5/kdevelop-3.4/lib/widgets/fancylistviewitem.cpp:78: 
error: definition of ‘void FancyKListViewItem::paintCell(QPainter*, 
const QColorGroup&, int, int, int)’ is not in namespace enclosing 
‘FancyKListViewItem’
/data/development/sources/kde-3.5/kdevelop-3.4/lib/widgets/fancylistviewitem.cpp:176: 
error: definition of ‘int FancyKListViewItem::textWidth(const QFont&, 
const QString&)’ is not in namespace enclosing ‘FancyKListViewItem’
/data/development/sources/kde-3.5/kdevelop-3.4/lib/widgets/fancylistviewitem.cpp:187: 
error: definition of ‘int FancyKListViewItem::width(const 
QFontMetrics&, const QListView*, int)’ is not in namespace enclosing 
‘FancyKListViewItem’
Error creating ./lib/widgets/fancyklistviewitem.lo. Exit status 1.


And sincerely things like these are very ugly:
fancyqlistviewitem.cpp:
#include "fancyqlistviewitem.h"
///this declares the item
#include "fancylistviewitem.cpp"

Why do you have to include once more the .cpp file?? 

This is also strange:
fancyqlistviewitem.h:
#define FANCYLISTVIEWITEM_NEWNAME FancyQListViewItem
#define FANCYLISTVIEWITEM_BASE QListViewItem

#include "fancylistviewitem.h"

No double inclusion guard, just some defines and an include in the 
header file. Why do you need all those defines and why do you include a 
header file into another one if you do not use it?

Andras

PS: And you still replied to a mail instead starting a new one...
PS2: Sorry for being harsh, but I was a little bit shocked when I looked 
at the code.


-- 
Quanta Plus developer - http://quanta.kdewebdev.org
K Desktop Environment - http://www.kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20060519/409a7a3c/attachment.sig>