view-not-closed-bug

[Matt Rogers]

On Friday 07 April 2006 04:08, David Nolden wrote:
> I downloaded and compiled the current kdevelop 3.4 svn, and it has a small
> very annoing bug, when I close a documentation-tab or -window, just the
> part is removed but the window/tab stays as an emty unremovable zombie.
>
> It is fixed with this mini-patch:
>
> Index: partcontroller.cpp
> ===================================================================
> --- partcontroller.cpp  (Revision 527194)
> +++ partcontroller.cpp  (Arbeitskopie)
> @@ -909,6 +909,7 @@
>          }
>          else if ( !ro_part->closeURL() )
>              return false;
> +        TopLevel::getInstance()->removeView( w );
>      }
>      else if ( !ro_part->closeURL() )
>          return false;
>
>
>
> Please tell me if I should mail such things to another place ;)
>
> greetings, David Nolden
>

looks good. I've applied your patch. It is best to send patches as attachments 
so we don't have to retype them in. This one was no problem though, so I went 
ahead and did it.

Thanks for the patch! Am looking forward to many more!
--
Matt