The full patch file for classviewer

[Escuder Nicolas]

Hello,

This patch is for the support of include files in the php support patch.

Sample :

The project dir is : /www/sites/application 
All projects file are in this directory but in php we can include class file
outside this directory ex:  /var/lib/php/includefile

So the classfile is in another project but the actual project must see it in
classviewer for displaying class of the application and php code
completition....

With c++ I don't see any problems...

The classviewer patch gives the permission to add file in classviewer that
are not in the project.

The classviewer patch is necessary before applying the php support part
patch.

I just want to known if all body are agree.
A second question: can i work with subversion directly for the directory
/languages/php and just submit in this directory my changes if kdevelop
build fine ?? (I have already an subversion account)

So I hope you understand all, I'm French and my English is not fine I think
;o)



[root at toad classview]# svn diff
Index: classviewwidget.cpp
===================================================================
--- classviewwidget.cpp (révision 421205)
+++ classviewwidget.cpp (copie de travail)
@@ -166,15 +166,13 @@
 void ClassViewWidget::insertFile( const QString& fileName )
 {
     QString fn = URLUtil::canonicalPath( fileName );
-    if( !m_part->project()->isProjectFile(fn) )
-       return;
     //kdDebug() << "======================== insertFile(" << fn << ")" <<
endl;
 
     FileDom dom = m_part->codeModel()->fileByName( fn );
     if( !dom )
        return;
 
-    fn = m_part->project()->relativeProjectFile( fn );
+    fn = URLUtil::relativePathToFile(m_part->project()->projectDirectory(),
fn);
     QStringList path;
 
     switch( viewMode() )
@@ -209,15 +207,13 @@
 void ClassViewWidget::removeFile( const QString& fileName )
 {
     QString fn = URLUtil::canonicalPath( fileName );
-    if( !m_part->project()->isProjectFile(fn) )
-       return;
     //kdDebug() << "======================== removeFile(" << fn << ")" <<
endl;
 
     FileDom dom = m_part->codeModel()->fileByName( fn );
     if( !dom )
        return;
 
-    fn = m_part->project()->relativeProjectFile( fn );
+    fn = URLUtil::relativePathToFile(m_part->project()->projectDirectory(),
fn);
     QStringList path;
 
     switch( viewMode() )

-----Message d'origine-----
De : kdevelop-devel-admin at barney.cs.uni-potsdam.de
[mailto:kdevelop-devel-admin at barney.cs.uni-potsdam.de] De la part de
Alexander Neundorf
Envoyé : mardi 31 mai 2005 21:10
À : kdevelop-devel at kdevelop.org; Escuder Nicolas
Objet : Re: The full patch file for classviewer

Hi Nicolas,

reviewing and applying patches is quite some work, and most developers
around 
here (there are not too many) are very busy.
So, your patch to the classviewwidget does the following:

-    if( !m_part->project()->isProjectFile(fn) )
-	return;
...
-    fn = m_part->project()->relativeProjectFile( fn );
+    fn = URLUtil::relativePathToFile(m_part->project()->projectDirectory(),

fn);

Do I understand correctly that this means that it also works with files 
outside the project directory ?
Why is this required ? Which effect does this have e.g. on the C++ support
in 
kdevelop ? 
What was the main reason to limit classviewwidget to files inside the
project 
directory ?

Btw. is your patch against current svn trunk ? If not, could you be so kind
to 
generate such a patch ?

Bye
Alex
-- 
Work: alexander.neundorf at jenoptik.com - http://www.jenoptik-los.de
Home: neundorf at kde.org                - http://www.kde.org
      alex at neundorf.net               - http://www.neundorf.net

_______________________________________________
KDevelop-devel mailing list
KDevelop-devel at barney.cs.uni-potsdam.de
http://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel