Fwd: KDE/kdevelop/src

[Andras Mantia]

On Monday 04 July 2005 09:11, Vladimir Prus wrote:
> On Saturday 02 July 2005 11:01, Andras Mantia wrote:
> > --- trunk/KDE/kdevelop/src/newmainwindow.cpp #430666:430667
> > @@ -127,7 +127,8 @@
> >      createActions();
> >      createStatusBar();
> >
> > -    createGUI(0);
> > +//    createGUI(0);
> > +    createShellGUI(true);
>
> My opinion probably does not matter much, but I think that leaving
> commented out code like this is a bad idea. Somebody else will
> eventually wonder if commented out code is supposed to be temporary
> disabled, or it's some workaround, or what else.

It was a temporary change locally that I forgot about. :-)

>
> Maybe, you can add a comment saying why 'createShellGUI' is better
> that 'createGUI'?

Not necessary better (after reading the code, as there is no 
documentation for createShellGUI), but  createGUI(0) when called the 
first time will do nothing more that call createShellGUI()... createGUI 
should be used to create a GUI and add a part.

Anyway, I will remove the commented out code.

Andras

-- 
Quanta Plus developer - http://quanta.kdewebdev.org
K Desktop Environment - http://www.kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20050704/3f6c8914/attachment.sig>