QuickOpenPart addition

[Ahn, Duk J.]

HI again!

Thank you for your interest.
I made second patch about your comment.
I have no against about your comment.
All of your comment are right.

But I have some questions for menu placement now.

I think File Menu best suits for Quick Open File..
Because It opens file.
And for a QuickOpen class and QuickOpen Function, You are right.

But I'm not an original author of this part.
And I have no permission(?) to decide it, right?

Please look at second patch and if you think there is no problem,
then you can apply patch into CVS.
And if you think there is some problem, then you can apply to CVS
with your modification or your addition.

Thank you.

Jens Dagerbo wrote:

 > -----BEGIN PGP SIGNED MESSAGE-----
 > Hash: SHA1
 >
 >
 > Re http://bugs.kde.org/show_bug.cgi?id=74941
 >
 > Hi,
 >
 > Very nice addition! I've used it for a few days and it works well.
 >
 > Some thoughts before we import it into CVS:
 >
 > # License. All source files added to CVS _should_ have a license 
header. (Not all have, but that's not intentional..)
 >
 > # .ui.h In general we tend to stay away from the .ui.h scheme since 
the KDE build system still doesn't work too well with them. Basically, a 
change to a .ui.h will not cause the related generated .cpp file to be 
rebuilt. This causes confusion and is best avoided.
 >
 > # .rc file version update
 > Whenever one changes a KDE XMLGUI .rc file, one has to also update 
the version number (found at the top of the file). If one neglects to do 
so, the change may or may not be noticed by the users, depending on 
wether or not they have made any related customizations.
 >
 >
 > Other, more general thoughts about the Quickopen plugin:
 >
 > # refactoring
 > There is now three dialog classes that have about 50 identical lines 
that as far as I can tell could be easily shared. I'll fix this unless 
someone else feels interested..
 >
 > # menu placement
 > Why do we have these in the "Edit" menu? Would they make more sense 
in the "Tools" menu? I'd like to put them there and also use "Quickopen" 
name to associate them with the Quickopen plugin.
 >
 > So: "Quickopen file", "Quickopen Class" and "Quickopen method" in the 
Tools menu. Any against? Or else I'll do this.
 >
 > jd
 >
 >
 >
 >
 > -----BEGIN PGP SIGNATURE-----
 > Version: GnuPG v1.2.3 (GNU/Linux)
 >
 > iD8DBQFAL5k56meJzsUuplQRAggjAKCrDf/ZsQEkZyuFD1c9YhqNCKP0CwCgi2VG
 > fhcQkLVg53KizAvGX6iFXNE=
 > =00Yv
 > -----END PGP SIGNATURE-----
 >
 >
 >


Jens Dagerbo wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> 
> Re http://bugs.kde.org/show_bug.cgi?id=74941
> 
> Hi,
> 
> Very nice addition! I've used it for a few days and it works well. :)
> 
> Some thoughts before we import it into CVS:
> 
> # License. 
> All source files added to CVS _should_ have a license header. (Not all have, 
> but that's not intentional..)
> 
> # .ui.h 
> In general we tend to stay away from the .ui.h scheme since the KDE build 
> system still doesn't work too well with them. Basically, a change to a .ui.h 
> will not cause the related generated .cpp file to be rebuilt. This causes 
> confusion and is best avoided.
> 
> # .rc file version update
> Whenever one changes a KDE XMLGUI .rc file, one has to also update the version 
> number (found at the top of the file). If one neglects to do so, the change 
> may or may not be noticed by the users, depending on wether or not they have 
> made any related customizations.
> 
> 
> Other, more general thoughts about the Quickopen plugin:
> 
> # refactoring
> There is now three dialog classes that have about 50 identical lines that as 
> far as I can tell could be easily shared. I'll fix this unless someone else 
> feels interested..
> 
> # menu placement
> Why do we have these in the "Edit" menu? Would they make more sense in the 
> "Tools" menu? I'd like to put them there and also use "Quickopen" name to 
> associate them with the Quickopen plugin.
> 
> So: "Quickopen file", "Quickopen Class" and "Quickopen method" in the Tools 
> menu. Any against? Or else I'll do this.
> 
> jd
> 
> 
> 
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.3 (GNU/Linux)
> 
> iD8DBQFAL5k56meJzsUuplQRAggjAKCrDf/ZsQEkZyuFD1c9YhqNCKP0CwCgi2VG
> fhcQkLVg53KizAvGX6iFXNE=
> =00Yv
> -----END PGP SIGNATURE-----
> 
> _______________________________________________
> Kdevelop-devel mailing list
> Kdevelop-devel at barney.cs.uni-potsdam.de
> http://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
> 
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: quickopen_addition_2.diff.gz
Type: application/x-tar
Size: 6976 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20040216/45621c7f/attachment.tar>