Hmm - here's a possible problem (Re: class libs/widget/KTabBar conflicts with class kdelibs/kdeui/KTabBar)

[jbb]

On Thu, 16 Oct 2003 11:38, Amilcar do Carmo Lucas wrote:
> The patch breaks KDE 3.1.3.
> Everything compiles fine, but in linking src/kdevelop I get an error in
> mainwindowideal.cpp:228 because the code for ktabwidget class is not
> linked with.

Sigh - what is the compat lib for? Only for kde versions < 3.1? Do we have a 
lib (besides qextmdi) for kde < 3.1.90 somewhere?

> PS remove the kdevelop.kdevelop part of the diff

Ok :-)

In the section
dnl  Very ugly hack to see whether QT_VERSION > 3.0.4. Remove it when
dnl  KDevelop needs Qt > 3.0.4 anyways

we have
      #if QT_VERSION < 305
Is this correct?

compare this to a test for qt3.1
      #if QT_VERSION < 0x030100

Strange, no?
At this stage I give up :-)

jbb

>
> jbb wrote:
> >Hi,
> >
> >This (corrected) patch works on kde cvs and I'm not crashing on exit
> > anymore.
> >
> >jbb
> >
> >On Wed, 15 Oct 2003 23:03, jbb wrote:
> >>On Wed, 15 Oct 2003 22:19, jbb wrote:
> >>Seems to be a night for replying to myself
> >>
> >>Here's a patch that could fix this problem. I'm compiling at the moment
> >> so it's untested. Could someone test on kdecvs kde3.1 and kde3.0 and
> >> apply. It moves ktabwidget.* from lib/widgets to lib/compat as well as
> >> fixes the compat includes on cvs.
> >>
> >>Seems to be compiling on kde cvs so far :-)
> >>
> >>'Nite folks,
> >>
> >>jbb
> >>
> >>>On Mon, 13 Oct 2003 19:20, Falk Brettschneider wrote:
> >>>(snip)
> >>>
> >>>>>>P.S.: Put KTabBar in a compat namespace similar like in
> >>>>>>lib/qextmdi/*_compat.h/cpp
> >>>>>
> >>>>>So they're the same thing then?
> >>>>
> >>>>Not sure but why do they have the same name?
> >>>
> >>>Hmm - was about to add ktabwidget.* to lib/compat but then noticed that
> >>>the following files
> >>>
> >>>/languages/cpp/Makefile.am:
> >>>./languages/sql/Makefile.am:
> >>>./languages/java/Makefile.am
> >>>./lib/util/Makefile.am:
> >>>./lib/widgets/Makefile.am
> >>>./lib/widgets/propeditor/Makefile.am
> >>>./vcs/cvs/Makefile.am:
> >>>./parts/fileview/Makefile.am:
> >>>./parts/classview/Makefile.am:
> >>>
> >>>all contain something like...
> >>>INCLUDES = ... -I$(top_srcdir)/lib/compat ...
> >>>
> >>>which will include the headers to the compat library, which on a kde cvs
> >>>version could cause problems?
> >>>
> >>>I think this should be removed for kde cvs. Is my reading of this
> >>>correct? If not, I have to hide the ktabwidget.* files somewhere else.
> >>>
> >>>See ya,
> >>>
> >>>jbb