Hmm - here's a possible problem (Re: class libs/widget/KTabBar conflicts with class kdelibs/kdeui/KTabBar)

[Amilcar do Carmo Lucas]

The patch breaks KDE 3.1.3.
Everything compiles fine, but in linking src/kdevelop I get an error in 
mainwindowideal.cpp:228 because the code for ktabwidget class is not 
linked with.

PS remove the kdevelop.kdevelop part of the diff


jbb wrote:

>Hi,
>
>This (corrected) patch works on kde cvs and I'm not crashing on exit anymore.
>
>jbb
>
>On Wed, 15 Oct 2003 23:03, jbb wrote:
>  
>
>>On Wed, 15 Oct 2003 22:19, jbb wrote:
>>Seems to be a night for replying to myself
>>
>>Here's a patch that could fix this problem. I'm compiling at the moment so
>>it's untested. Could someone test on kdecvs kde3.1 and kde3.0 and apply. It
>>moves ktabwidget.* from lib/widgets to lib/compat as well as fixes the
>>compat includes on cvs.
>>
>>Seems to be compiling on kde cvs so far :-)
>>
>>'Nite folks,
>>
>>jbb
>>
>>    
>>
>>>On Mon, 13 Oct 2003 19:20, Falk Brettschneider wrote:
>>>(snip)
>>>
>>>      
>>>
>>>>>>P.S.: Put KTabBar in a compat namespace similar like in
>>>>>>lib/qextmdi/*_compat.h/cpp
>>>>>>            
>>>>>>
>>>>>So they're the same thing then?
>>>>>          
>>>>>
>>>>Not sure but why do they have the same name?
>>>>        
>>>>
>>>Hmm - was about to add ktabwidget.* to lib/compat but then noticed that
>>>the following files
>>>
>>>/languages/cpp/Makefile.am:
>>>./languages/sql/Makefile.am:
>>>./languages/java/Makefile.am
>>>./lib/util/Makefile.am:
>>>./lib/widgets/Makefile.am
>>>./lib/widgets/propeditor/Makefile.am
>>>./vcs/cvs/Makefile.am:
>>>./parts/fileview/Makefile.am:
>>>./parts/classview/Makefile.am:
>>>
>>>all contain something like...
>>>INCLUDES = ... -I$(top_srcdir)/lib/compat ...
>>>
>>>which will include the headers to the compat library, which on a kde cvs
>>>version could cause problems?
>>>
>>>I think this should be removed for kde cvs. Is my reading of this
>>>correct? If not, I have to hide the ktabwidget.* files somewhere else.
>>>
>>>See ya,
>>>
>>>jbb
>>>
>>>
>>>      
>>>

-- 
Amilcar Lucas