CMakeOutputView revisited - patch

[F@lk Brettschneider]

Hi!
Thanks a lot for your work.
But
1.) Isn't this fixed in cvs by Harald, already?
2.) Isn't KDE-3.0.1 already tagged? So KDevelop-2.1.1 may technically be 
released, already.
3.) Does your patch also work with the Qt version released along with 
KDE-3.0.0? As far as I know it was just a special bug with SuSE-8.0, 
wasn't it?
Ciao
F at lk



Marcus Gruendler wrote:

>Hi all,
>
>Some time ago I posted a patch that fixed the CMakeOutputWidget in order to 
>jump to errors. This patch was for KDevelop 2.1 under KDE 2.2.x. Now I have 
>updated my system to KDE 3 and wanted to use KDevelop again. 
>
>Unfortunately there was a problem with the CMakeOutputWidget again. This time 
>all compiler messages were put into one line and word wrapped at the widget 
>border. This is quite annoying since it is hardly possible to understand any 
>compiler error or warning. And even worse, it was not possible to jump to an 
>error via F4/Shift F4.
>
>So I had another look at the source and have provided a patch for the problem. 
>For those who are interested in the details: The rich text tags of the line 
>had to be changed from 
>
>	<font ...> line </font><br> 
>to 
>	<p><font ...> line </font></p>
>
>And I switched word wrapping of. Now everything works fine under KDE3. I 
>didn't change anything for KDE 2.x since the code is seperated by #ifdefs.
>
>I know that the KDE_2_2_BRANCH of KDevelop is actually closed, but this patch 
>fixes a heavy bug (or mis-feature ;) which makes KDevelop unusable under 
>KDE3. So I kindly ask you to apply the patch for an upcoming service release 
>of KDE.
>
>If you have any other questions, feel free to ask me...
>
>Bye, Marcus
>
>
>
>
>------------------------------------------------------------------------
>
>Index: kdevelop/coutputwidget.cpp
>===================================================================
>RCS file: /cvs/kdevelop/kdevelop/coutputwidget.cpp,v
>retrieving revision 1.3.2.4.2.10.2.16
>diff -u -3 -r1.3.2.4.2.10.2.16 coutputwidget.cpp
>--- kdevelop/coutputwidget.cpp	2002/04/10 14:50:32	1.3.2.4.2.10.2.16
>+++ kdevelop/coutputwidget.cpp	2002/05/15 17:33:45
>@@ -78,10 +78,12 @@
> {
>   it = m_errorMap.begin();
>   setReadOnly(true);        // -JROC uncommented again
>-  setWordWrap(WidgetWidth); // -JROC
>-  setWrapPolicy(Anywhere); // -JROC
> #if QT_VERSION >= 300
>   setTextFormat(Qt::RichText);
>+  setWordWrap(NoWrap);
>+#else
>+  setWordWrap(WidgetWidth); // -JROC
>+  setWrapPolicy(Anywhere); // -JROC
> #endif
> }
> 
>@@ -120,15 +122,15 @@
>     switch (lineType(paraCount))
>     {
>       case Error:
>-        line = "<font color=\"darkRed\">" + line + "</font><br>";
>+        line = "<p><font color=\"darkRed\">" + line + "</font></p>";
>         append(line);
>         break;
>       case Diagnostic:
>-        line = "<font color=\"darkBlue\">" + line + "</font><br>";
>+        line = "<p><font color=\"darkBlue\">" + line + "</font></p>";
>         append(line);
>         break;
>       default:
>-        append(line + "<br>");
>+        append("<p>" + line + "</p>");
>         break;
>     }
> 
>