Bug#39636: marked as done (Cannot add a new Icon to a project) by Harald Fernengel <harry at kdevelop.org>

[Stephan Kulow]

Your message with subj: Fixed in CVS

Hi,

the patch has been applied to current CVS, thank you very much for report=
ing=20
it.

Best regards,
Harry

has caused the attached bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I'm
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Stephan Kulow
(administrator, KDE bugs database)

Received: (at submit) by bugs.kde.org; 21 Mar 2002 23:00:54 +0000
Received: (qmail 18449 invoked by uid 33); 21 Mar 2002 23:00:54 -0000
Date: 21 Mar 2002 23:00:54 -0000
Message-ID: <20020321230054.18446.qmail at mail.kde.org>
To: submit at bugs.kde.org
Subject: Cannot add a new Icon to a project
From: tim at electronghost.co.uk
X-KDE-Received: -62.253.128.6

Package:           kdevelop
Version:           2.1 (using KDE 2.9.0 9 (3.0 rc3))
Severity:          normal
Installed from:    Red Hat Linux 7.2.92
Compiler:          gcc version 2.96 20000731 (Red Hat Linux 7.2 2.96-107)
OS:                Linux (i686) release 2.4.17-0.18
OS/Compiler notes: 

Right-click a directory, select 'New file', choose the Linux/KDE tab and 'Icon'

No matter what filename you enter, you will get an error saying "The filename must end with .png or .xpm !"

This is because the comparison:

if ( (fileType() == "ICON") && (text.right(4) != ".png" || text.right(4) != ".xpm")){

is wrong and should read

if ( (fileType() == "ICON") && !(text.right(4) == ".png" || text.right(4) == ".xpm")){

in cnewfiledlg.cpp



(Submitted via bugs.kde.org)
(Called from KBugReport dialog)