Bug#39636: Cannot add a new Icon to a project

[tim at electronghost.co.uk]

Package: kdevelop
Version: 2.1 (using KDE 2.9.0 9 (3.0 rc3))
Severity: normal
Installed from:    Red Hat Linux 7.2.92
Compiler:          gcc version 2.96 20000731 (Red Hat Linux 7.2 2.96-107)
OS:                Linux (i686) release 2.4.17-0.18
OS/Compiler notes: 

Right-click a directory, select 'New file', choose the Linux/KDE tab and 'Icon'

No matter what filename you enter, you will get an error saying "The filename must end with .png or .xpm !"

This is because the comparison:

if ( (fileType() == "ICON") && (text.right(4) != ".png" || text.right(4) != ".xpm")){

is wrong and should read

if ( (fileType() == "ICON") && !(text.right(4) == ".png" || text.right(4) == ".xpm")){

in cnewfiledlg.cpp



(Submitted via bugs.kde.org)
(Called from KBugReport dialog)