More KDevelop patches

[W. Tasin]

Hi *,

I think the complete patch shouldn't be done before releasing (only if 
the corrisponding specialist will take care of the single parts and 
considers it as important for the next release).
We are in feature freeze and I have some problems with this patch.

1) jbb could you have a look at the debug parts of this patch?
     I'm not quite sure, but if IIRC there were some problems with 
KListView, right?

2) IIRC it is still possible that var_viewer can be 0 (switch to 
external debugger), so a test for it before calling   
var_viewer->parent() would be great (or disable all corrisponding menu 
items on !dbgInternal, which would be better IMHO)

3) I don't know much about the MDI-part, but comparing it with other 
code-elements showed me some differences.
Isn't there a setFocus missing? Falk could you check this (when you will 
come back from cebit)?

4) AFAICS useGlimpse is a variable which tells KDevelop if glimpse has 
been found (ok the naming lacks, for historical reason, so maybe this 
should be changed to "foundGlimpse" first to see the real problem) . 
IMHO it shouldn't be set to false if htdig was found. A better way is to 
use the variable "engine" for search.
So I think the problem is at ckdevelop.cpp:line 2679 (removing this 
line)  and ckdevelop.cpp:line 3371+ (using engine && useGlimpse), but 
convince me if I'm wrong.
 
5) Can sb. else test the workaround with openURL("file:/") (with KDE 2 
and KDE 3) and take care of the filter-patch. I think the filter-patch 
doesn't harm.


Unfortunately I cannot take care of this patch, because there are some 
other problems I have to look first.

Nir please don't think that I wouldn't like your patches ;-) [go 
ahead... ] .
I'm actually only a little bit sensible, because we want to release soon 
and every patch have to be reviewed "ten times" before committing.

Ciao

Walter

Nir Mardiks wrote:

>(sorry about the previous bad patches, hopefully the patches I make are 
>getting better).
>
>Anyhow, the patches included contain the following:
>A) Fix so that if you correct a re-search an help on - the window will 
>refresh itself. Previously, the file on the disk was updated but KDevelop's 
>help window continued to show the previous search result.
>B) A change so that whenever the user asks to watch a variable from the 
>editor - KDevelop makes sure the watches tab is visible
>C) New list of file types for the file->open dialog to contain all the file 
>types known (taken from CProject)
>D) Fix, for computers which have glimpse and htdig, when the user works with 
>htdig - the search failed because useGlimpse contained true for some reason.
>E) A few changes for the Watches:
>    1) Now the watches pane can be traversed using the keyboard (made 
>focusable).
>    2) Watches can be deleted using DEL key.
>    3) Watches can be updated by double-clicking on them and editing the text 
>(or right-click -> Update watch variable)
>
>That's about it...
>
>Two things I couldn't fix that really annoyed me:
>1) For some reason in the update watch variable, calling rename() only once 
>didn't work - I had to call rename() twice... - any idea ?
>2) KLineEdit seems to have a bug which causes enterPressed to be called twice 
>(this makes the same variable appear twice in the watches pane).
>3) KHTMLPart doesn't seem to have a refresh function - had to call 
>openURL("file:/") before re-opening the real URL to make things work...
>
>Hopefully you'll find the patches useful,
>  Nir.
>

-- 
oohhh sveglia.... il mondo e' ammalato, ma x colpa di chi.........
(Zucchero)
:-------W._Tasin,_FB_04,_FHM-------------------PGP-KeyID:0x7961A645---:
<Key-Fingerprint: 1610 835F 0080 32F4 6140  6CF7 A7D0 44CD 7961A645>
<http://wwwkeys.pgp.net:11371/pks/lookup?op=index&search=0x7961A645&fingerprint=on>