PATCH: crash fixed, was Re: Committed Kuba's patches

Kuba Ober kuba at mareimbrium.org
Wed Jun 5 21:29:02 UTC 2002


On środa 05 czerwiec 2002 02:36 pm, Roland Krause wrote:
> The attached patch fixes the crash upon hitting the tab key in the
> first line of a file.
>
> I felt guilty since I didnt catch this before I applied to CVS, so here
> it goes.

This one nicely fixes this problem, and the fact that opening brace 
indentation actually didn't do what it was supposed to. We're looking at 
indenting deeper based on opening brace in our reference line -- the line 
somewhere above, not in the current line. The fix is what 
textLine=contents.current() does, because current contents pointer was moved 
to the reference line by seekIndentRef()

Opening-parentheses indentation patches will follow maybe tomorrow + block 
(selection) indentation + make tab indent just like newline does (i.e. 
preserve tabs/spaces).

Cheers, Kuba Ober
-------------- next part --------------
A non-text attachment was scrubbed...
Name: indent-fix.patch
Type: text/x-diff
Size: 4535 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20020605/75088d1b/attachment.bin>


More information about the KDevelop-devel mailing list