PATCH: crash fixed, was Re: Committed Kuba's patches

Roland Krause rokrau at yahoo.com
Wed Jun 5 20:37:03 UTC 2002


The attached patch fixes the crash upon hitting the tab key in the
first line of a file. 

I felt guilty since I didnt catch this before I applied to CVS, so here
it goes. 

Roland



--- Sebastian Kratzert <skratzert at gmx.de> wrote:
> Am Mittwoch, 5. Juni 2002 00:21 schrieb Roland Krause:
> > I committed Kuba's patches for the indentation today. Please check
> them
> > out. I recommend updating since this makes the editor much more
> > convenient even for people that dont know what kernel style
> indentation
> > is. The output widget crash with the broken Qt-3.0.4 libs is fixed
> > also.
> >
> > Anything else, ah yes, grep is now egrep and looks for .P .Po and
> .Plo
> > files when generating a tags file.
> >
> > As always, "test it or regret it" ...
> >
> > Roland
> 
> Hi
> 
> Now the automake/autoconf dissapeared, but I have another issue..
> When I compile something which has an error I always have to click
> one line 
> above the line where the eror is reported in COutputWidget to go to
> the 
> error.
> The attached patch fixes it.
> 
> best regards,
> Sebatian
> 
> > --- coutputwidget.cpp	Wed Jun  5 01:53:06 2002
> +++ ../coutputwidget.cpp	Wed Jun  5 01:52:03 2002
> @@ -124,7 +124,7 @@
>      int currentPara;
>      int index;
>      getCursorPosition(&currentPara, &index);
> -    int paraCount = paragraphs()-1;
> +    int paraCount = paragraphs();
>      bool displayAdditions = (paraCount == currentPara);
>  
>      // escape rich edit tags like "&", "<", ">"
> @@ -291,7 +291,7 @@
>    {
>      // add the error keyed on the line number in the make output
> widget
>      ErrorDetails errorDetails(fileInErr, lineInErr, type);
> -    m_errorMap.insert(numLines()-1, errorDetails);
> +    m_errorMap.insert(numLines(), errorDetails);
>    }
>  }
>  
> 

__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kwdoc.cpp.patch
Type: text/x-diff
Size: 1013 bytes
Desc: kwdoc.cpp.patch
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20020605/6d5f94b7/attachment.bin>


More information about the KDevelop-devel mailing list