Problem with KDE 2.1 with KDE 3.0 beta 2

[Falk Brettschneider]

Hi Jens,

Jens Zurheide wrote:

>Monday 25 February 2002 21:59 Falk Brettschneider
>
>>Hi,
>>
>>I didn't apply the patch because was announced as only
>>working with KDE3.
>>Please, send the patch again working for KDE 2 and KDE
>>3.
>>
>>Cheers,F at lk
>>
>Ouch, I have never seen so many merging conflicts in one file.
>
Hehehe...I started an own hack....

> After sorting 
>out all of them it is possible to define the colors of the documentation 
>browser. But I am still not sure if allowing to change the colors is a good 
>idea despite the fact that you could have a good laugh as I had when I 
>switched the normal text color to yellow. The reasons are:
>- The colors do not update immediately and I really don't know why. You have 
>to close the documentation window and reopen it.
>- Changing the foreground color changes the color of all menu entries after 
>a restart of KDevelop. The color of the combobox arrows changes as well. 
>Might look funny but is certainly not what you expect.
>- At least the link color and the color for already visited links are 
>hardcoded into the Qt documentation and the KDE documentation uses CSS 
>files.
>
>If the font size settings don't have any effect this is due to a bug in 
>khtml. Patch appended. Maybe someone could forward it to the appropriate 
>mailing list/maintainer.
>
Excellent! Thanks a lot!
I've applied it to cvs for further testing and trying.
The khtml patch has been sent to kde-core-devel at kde.org. Let's hope the 
apply it, too.

Cheers,F at lk

>
>
>Ciao,
>Jens
>
>
>------------------------------------------------------------------------
>
>Index: khtml_settings.cc
>===================================================================
>RCS file: /home/kde/kdelibs/khtml/khtml_settings.cc,v
>retrieving revision 1.84
>diff -3 -w -u -p -r1.84 khtml_settings.cc
>--- khtml_settings.cc	2002/01/29 12:54:16	1.84
>+++ khtml_settings.cc	2002/02/26 21:29:52
>@@ -431,7 +431,7 @@ void KHTMLSettings::resetFontSizes()
>     if ( sizeAdjust > 9 )
>         sizeAdjust = 9;
>     //kdDebug(6050) << "KHTMLSettings::resetFontSizes adjustment is " << sizeAdjust << endl;
>-    const float factor = 1.2;
>+    const float factor = 1.2F;
>
What is F? The same as f?

>
>     float scale = 1.0 / ( factor*factor*factor );
>     for ( int i = 0; i < MAXFONTSIZES; i++ ) {
>               d->m_fontSizes << ( KMAX( int( d->m_fontSize * scale + 0.5), d->m_minFontSize ) );
>




_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com