[Patch] Gideon

[Simon Hausmann]

On Sun, Sep 30, 2001 at 03:14:30AM +0200, Otto Bruggeman wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On Sun, 30 Sep 2001, Bernd Gehrmann wrote:
> > If you display the message box in PartLoader::loadService(), why do you
> > display it again in the calling routines?
> >
> > Bernd.
> 
> Uhm... to be honest i did not look into the code very much but when i
> fixed the error in partLoader i kept seeing more null pointer crashes so i
> fixed them all similarly... might have overdone it overdone it with
> the messageboxes because i am not familiar with the code... a simple if
> (!part) return; would be enough then i guess. Revised version attached.

Another thought. Instead of
> +        if (!factory) {
> +            KMessageBox::error(0, i18n("Error: could not load part! Is it corrupt, binary incompatible or installed in the wrong directory, like $KDEDIR/lib/kde(2) instead of $KDEDIR/lib/kde3 ?"));
> +        }

how about providing the actual error message from libltdl? A bit like
Konqueror does, when it cannot load a part (see KMessageBox in
konqueror/konq_factory.cc) , using KLibLoader::self()->lastErrorMessage() .

Just an idea :)

Simon

-
to unsubscribe from this list send an email to kdevelop-devel-request at kdevelop.org with the following body:
unsubscribe »your-email-address«