[akregator] [Bug 429444] Cannot delete feeds or folders

[Laurent Montel]

https://bugs.kde.org/show_bug.cgi?id=429444

Laurent Montel <montel at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/pim/
                   |                            |akregator/commit/2f6d4e233a
                   |                            |e8178535d74c1da0cf75a54762d
                   |                            |165

--- Comment #5 from Laurent Montel <montel at kde.org> ---
Git commit 2f6d4e233ae8178535d74c1da0cf75a54762d165 by Laurent Montel, on
behalf of Tomáš Trnka.
Committed on 11/04/2021 at 12:39.
Pushed by mlaurent into branch 'master'.

Treat feed IDs as unsigned everywhere

This fixes several bugs introduced by commit
230b8f20e1c042fecd814328755815356217eb62
("Port all instance of KRandom") which switched the random number
generator used in FeedList::generateId() from KRandom to
QRandomGenerator. The former generates positive signed integers while
the latter generates unsigned ints. While TreeNode already used uint to
store the IDs, other classes used plain int. Half of the newly generated
IDs thus got mapped to negative values, confusing various validity
checks.

M  +3    -3    src/command/deletesubscriptioncommand.cpp
M  +2    -2    src/command/deletesubscriptioncommand.h
M  +4    -4    src/command/editsubscriptioncommand.cpp
M  +2    -2    src/command/editsubscriptioncommand.h
M  +4    -4    src/command/expireitemscommand.cpp
M  +2    -2    src/command/expireitemscommand.h
M  +5    -5    src/feed/feedlist.cpp
M  +3    -3    src/feed/feedlist.h
M  +6    -6    src/subscription/subscriptionlistjobs.cpp
M  +9    -9    src/subscription/subscriptionlistjobs.h
M  +1    -1    src/subscription/subscriptionlistmodel.cpp

https://invent.kde.org/pim/akregator/commit/2f6d4e233ae8178535d74c1da0cf75a54762d165

-- 
You are receiving this mail because:
You are the assignee for the bug.