[kmail2] [Bug 387873] can no longer drag/drop a message from message list to favorites

David Faure bugzilla_noreply at kde.org
Tue Dec 19 22:12:00 GMT 2017


https://bugs.kde.org/show_bug.cgi?id=387873

David Faure <faure at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/mai
                   |                            |lcommon/ace9cfb46008e4fcd2b
                   |                            |973111fbc508110bbd9c9
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from David Faure <faure at kde.org> ---
Git commit ace9cfb46008e4fcd2b973111fbc508110bbd9c9 by David Faure.
Committed on 19/12/2017 at 22:11.
Pushed by dfaure into branch 'master'.

Fix dropping of emails onto favorites

Summary:
and dropping a collection to define a new favorite.

Test Plan:
Tested all three features, reordering, adding, and dropping a mail.

Two issues left:
- adding a new favourite at a specific position (patch pending
      for akonadi's favoritecollectionsmodel)
- the "+" when moving to reorder shouldn't appear, should be MoveAction only,
      don't know if that's possible here though.

Reviewers: dvratil, mlaurent, mkoller

Reviewed By: dvratil

Subscribers: #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D9403

M  +0    -10   src/folder/favoritecollectionorderproxymodel.cpp
M  +0    -2    src/folder/favoritecollectionorderproxymodel.h
M  +47   -9    src/widgets/favoritecollectionwidget.cpp
M  +2    -0    src/widgets/favoritecollectionwidget.h

https://commits.kde.org/mailcommon/ace9cfb46008e4fcd2b973111fbc508110bbd9c9

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Kdepim-bugs mailing list