[Bug 306323] [kdepimlibs] missed boost dependency in KdepimLibsConfig.cmake.in

[Alex Turbov]

https://bugs.kde.org/show_bug.cgi?id=306323

--- Comment #14 from Alex Turbov <i.zaufi at gmail.com> ---
(In reply to comment #13)
> The idea and the patch are both wrong.
> 
> - Adding the boost include dir to kdepimlibs_include_dirs supposes that :
> 1/ Boost was already found,
yes it was! it was detected by root's CMakeLists.txt while compile... after
that, if pykde for example, starts to compile on same host boost definitely
will be here.
If we are talking about binary distros (like debian/rh) it is job of
distromaker to add an interpackage dependency kdepimlibs-dev on boost-dev.
btw, the way a *redistributable configuration file* generated in kdepimlibs is
incorrect!! It is invalid to use `set()`! Use `set_and_check() instead to make
sure desired paths really exists! (read details in cmake's manual about
CMakePackageConfigHelpers module)

> 2/ All of kdepimlibs needs boost
yes, they are!
according root CMakeLists.txt boost detected and set to include_directories
*unconditionally* -- so ALL kdepimlibs use boost!


> 
> These two statements are incorrect. Adding a find_package(boost) is excluded
NO IT DOESN'T! Check CMakeLists.txt in the source root...

-- 
You are receiving this mail because:
You are the assignee for the bug.