[Bug 306323] [kdepimlibs] missed boost dependency in KdepimLibsConfig.cmake.in

Christophe Giboudeaux cgiboudeaux at gmx.com
Fri Sep 7 16:46:49 BST 2012


https://bugs.kde.org/show_bug.cgi?id=306323

--- Comment #13 from Christophe Giboudeaux <cgiboudeaux at gmx.com> ---
The idea and the patch are both wrong.

- Adding the boost include dir to kdepimlibs_include_dirs supposes that :
1/ Boost was already found,
2/ All of kdepimlibs needs boost

These two statements are incorrect. Adding a find_package(boost) is excluded
because of 2 and the posted patch is wrong because of 1.

And even without 1 & 2, that would mean we'd have to support FindBoost.cmake
which supposes that you have a high confidence in the boost SC (and in that
case, you're also terribly wrong). 

Oh and I won't mention the boost attempt to provide a BoostConfig.cmake which
is in no way compatible with FindBoost.cmake...

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Kdepim-bugs mailing list