Review Request 129034: improve library/playlist clip import by detecting duplicate producers

[The DiveO]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129034/
-----------------------------------------------------------

(Updated Sept. 27, 2016, 11:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for Kdenlive.


Changes
-------

Submitted with commit 380e508f3e5712b75aebc22ae8dceb92efcf3a9f by Jean-Baptiste Mardelle to branch master.


Repository: kdenlive


Description
-------

As it seems, MLT during export produces duplicate producers for image clips, title clips, and color clips. It is arguable if this is an MLT issue, or not. Anyway, in order to improve the situation to Kdenlive library users, this patch adds a duplicate producer detection to the playlist import.
- duplicate producers are detected only for MLT services pixbuf, kdenlivetitle, color/colour.
- duplicate producers are detected on the basis of a hash value calculated over properties kdenlive:clipname and kdenlive:foldername, as well as:
  - kdenlivetitle: property kdenlive:xmldata
  - pixbuf, color/colour: property resource.
This patch ensures that only a single bin clip will be used for these duplicate playlist producers.

In addition, this patch improves on user error reporting in exportTimelineSelection.


Diffs
-----

  src/bin/bin.cpp a20632a 
  src/timeline/customtrackview.cpp 6338296 

Diff: https://git.reviewboard.kde.org/r/129034/diff/


Testing
-------

Tested on recent git master.


Thanks,

The DiveO

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20160927/440ef18f/attachment.html>