Review Request 129034: improve library/playlist clip import by detecting duplicate producers

The DiveO thediveo at gmx.eu
Mon Sep 26 20:44:35 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129034/
-----------------------------------------------------------

Review request for Kdenlive.


Repository: kdenlive


Description
-------

As it seems, MLT during export produces duplicate producers for image clips, title clips, and color clips. It is arguable if this is an MLT issue, or not. Anyway, in order to improve the situation to Kdenlive library users, this patch adds a duplicate producer detection to the playlist import.
- duplicate producers are detected only for MLT services pixbuf, kdenlivetitle, color/colour.
- duplicate producers are detected on the basis of a hash value calculated over properties kdenlive:clipname and kdenlive:foldername, as well as:
  - kdenlivetitle: property kdenlive:xmldata
  - pixbuf, color/colour: property resource.
This patch ensures that only a single bin clip will be used for these duplicate playlist producers.

In addition, this patch improves on user error reporting in exportTimelineSelection.


Diffs
-----

  src/bin/bin.cpp a20632a 
  src/timeline/customtrackview.cpp 6338296 

Diff: https://git.reviewboard.kde.org/r/129034/diff/


Testing
-------

Tested on recent git master.


Thanks,

The DiveO

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20160926/c336742d/attachment.html>


More information about the kdenlive mailing list