Review Request 129145: UI access to libavfilter's lut effect

[Jean-Baptiste Mardelle]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129145/#review99998
-----------------------------------------------------------



Thanks for the patch. It looks like you forgot to include the apply_lut.xml file defining the filter. Also, to make things easier, we usually call the xml file by its MLT id, so more like avfilter_lut3d.xml

- Jean-Baptiste Mardelle


On Oct. 12, 2016, 10:19 p.m., alcinos alcinos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129145/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 10:19 p.m.)
> 
> 
> Review request for Kdenlive.
> 
> 
> Repository: kdenlive
> 
> 
> Description
> -------
> 
> This simply exposes access to the LUT effect of libavfilter. This is for initial review only and probably shouldn't be merged right away for several reasons:
>  * There is a bug in melt regarding this effect that needs to be fixed first (affects users with european locale). See https://github.com/mltframework/mlt/issues/130
>  * The UI is not optimally pretty because I cannot get the URL Picker to behave nicely (it takes all space possible instead of justifying to the right as a text field for example)
>  * It is proably time to define a standard way to define the extension filters of the urlpicker. Currently the xml object corresponding to an url has no way to define this (and I had to temporarily disable filtering altogether in the code)
>  * I've set a "full" description of the filter but I don't see where it is showing up in the current UI.
> 
> 
> Diffs
> -----
> 
>   data/blacklisted_effects.txt eaa8303 
>   data/effects/README 5fff9ef 
>   data/effects/avfilter/CMakeLists.txt 2260572 
>   data/kdenliveeffectscategory.rc c645229 
>   src/effectstack/parametercontainer.cpp 9136892 
>   src/ui/urlval_ui.ui 68901f4 
> 
> Diff: https://git.reviewboard.kde.org/r/129145/diff/
> 
> 
> Testing
> -------
> 
> Works on latest master with a US locale.
> 
> 
> Thanks,
> 
> alcinos alcinos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdenlive/attachments/20161014/b55e4699/attachment.html>