<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129145/">https://git.reviewboard.kde.org/r/129145/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for the patch. It looks like you forgot to include the apply_lut.xml file defining the filter. Also, to make things easier, we usually call the xml file by its MLT id, so more like avfilter_lut3d.xml</p></pre>
<br />
<p>- Jean-Baptiste Mardelle</p>
<br />
<p>On October 12th, 2016, 10:19 p.m. UTC, alcinos alcinos wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kdenlive.</div>
<div>By alcinos alcinos.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2016, 10:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdenlive
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This simply exposes access to the LUT effect of libavfilter. This is for initial review only and probably shouldn't be merged right away for several reasons:
* There is a bug in melt regarding this effect that needs to be fixed first (affects users with european locale). See https://github.com/mltframework/mlt/issues/130
* The UI is not optimally pretty because I cannot get the URL Picker to behave nicely (it takes all space possible instead of justifying to the right as a text field for example)
* It is proably time to define a standard way to define the extension filters of the urlpicker. Currently the xml object corresponding to an url has no way to define this (and I had to temporarily disable filtering altogether in the code)
* I've set a "full" description of the filter but I don't see where it is showing up in the current UI.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works on latest master with a US locale.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/blacklisted_effects.txt <span style="color: grey">(eaa8303)</span></li>
<li>data/effects/README <span style="color: grey">(5fff9ef)</span></li>
<li>data/effects/avfilter/CMakeLists.txt <span style="color: grey">(2260572)</span></li>
<li>data/kdenliveeffectscategory.rc <span style="color: grey">(c645229)</span></li>
<li>src/effectstack/parametercontainer.cpp <span style="color: grey">(9136892)</span></li>
<li>src/ui/urlval_ui.ui <span style="color: grey">(68901f4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129145/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>